RFR: 8332899: RISC-V: add comment and make the code more readable (if possible) in MacroAssembler::movptr [v2]

Hamlin Li mli at openjdk.org
Fri May 31 15:04:39 UTC 2024


On Fri, 31 May 2024 14:49:47 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   typo
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 1686:
> 
>> 1684:   // In case of 11th bit of `lower` is 0, it's straightforward to understand.
>> 1685:   // In case of 11th bit of `lower` is 1, it's a bit tricky, to help understand,
>> 1686:   // image divide both `upper` and `lower` into 2 parts respectively, i.e.
> 
> Suggestion: s/image/imagine/

Thanks, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19431#discussion_r1622556913


More information about the hotspot-dev mailing list