RFR: 8341194: [REDO] Implement C2 VectorizedHashCode on AArch64 [v2]
Andrew Haley
aph at openjdk.org
Mon Nov 4 13:13:32 UTC 2024
On Tue, 8 Oct 2024 09:47:47 GMT, Mikhail Ablakatov <duke at openjdk.org> wrote:
>> Fix and redo [JDK-8322770](https://bugs.openjdk.org/browse/JDK-8322770) which got backed out in [JDK-8341197](https://bugs.openjdk.org/browse/JDK-8341197) due to test failures / jlink failure. Initial PR: https://github.com/openjdk/jdk/pull/18487.
>>
>> Compared to the initial PR, this one eliminates a mismatch between the `arrays_hashcode()` template and stub. The template defined v0-v7 & v12-v17 as TEMP registers but the stub used v8-v9 which were not on the list. Changing v8-v9 in the stub to v12-v13 eliminates this mismatch. Other changes in aarch64.ad is just a cleanup as some registers on the list were not used by the stub at all anymore.
>>
>> Following the discussion on [JDK-8341197](https://bugs.openjdk.org/browse/JDK-8341197), we've added a `make bootcycle-images` step to our local CI pipeline to verify that the issue is fixed.
>
> Mikhail Ablakatov has updated the pull request incrementally with one additional commit since the last revision:
>
> Ensure that the inline code and the stub use the same registers
Still good.
-------------
Marked as reviewed by aph (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21286#pullrequestreview-2413025116
More information about the hotspot-dev
mailing list