RFR: 8343167: Unnecessary define checks in InterpreterRuntime after JDK-8199809

Coleen Phillimore coleenp at openjdk.org
Mon Nov 4 13:21:28 UTC 2024


On Mon, 28 Oct 2024 19:36:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> [JDK-8199809](https://bugs.openjdk.org/browse/JDK-8199809) left a few unnecessary things in InterpreterRuntime::SignatureHandlerGenerator::SignatureHandlerGenerator. In `interpreterRT_x86_64.cpp`: no need for `AMD64` checks. In `interpreterRT_x86_32.cpp`: no need for `AMD64` and `WIN64` checks. 
> 
> Additional testing:
>  - [x] Linux x86_64 server fastdebug, `make bootcycle-images`
>  - [x] Linux x86_32 server fastdebug, `make bootcycle-images`
>  - [x] GHA

Sorry I didn't see this.  This looks fine.  Hopefully the _32 file can get removed soon.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21747#pullrequestreview-2413046086


More information about the hotspot-dev mailing list