RFR: 8343430: RISC-V: C2: Remove old trampoline call [v2]

Fei Yang fyang at openjdk.org
Tue Nov 5 02:35:28 UTC 2024


On Mon, 4 Nov 2024 13:33:50 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Comment
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 1597:
> 
>> 1595: 
>> 1596:   enum NativeFarCall {
>> 1597:     trampoline_size        = 1 * instruction_size + wordSize,
> 
> Call address stub size?

I am a bit worried that `MacroAssembler::NativeShortCall` could be confusing with `MacroAssembler::far_call` in naming, so I simply removed this enum. I also improved the code comment about different types of calls. Let me know.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21822#discussion_r1828646165


More information about the hotspot-dev mailing list