RFR: 8342893: Highlight special values in hserr file printing [v2]

Matthias Baesken mbaesken at openjdk.org
Tue Nov 5 11:36:32 UTC 2024


On Mon, 4 Nov 2024 21:07:32 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   compile error on Linux x86 and arm 32bit
>
> src/hotspot/share/runtime/os.cpp line 1346:
> 
>> 1344: #ifndef PRODUCT
>> 1345:     // corruption or uninitialized access pattern
>> 1346:     const intptr_t pat = 0xabababababababab;
> 
> How about constructing this from `badResourceValue`?

We could also put another variable centrally next to badResourceValue , see 
https://github.com/openjdk/jdk/blob/4fc6d4135e795d18a024a6035908f380b81082d1/src/hotspot/share/utilities/globalDefinitions.hpp#L1044
do you have a good naming for this ? Maybe `badZapValue` ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21811#discussion_r1829197572


More information about the hotspot-dev mailing list