RFR: 8342893: Highlight special values in hserr file printing [v2]

[Dean Long]

On Tue, 5 Nov 2024 11:33:28 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> src/hotspot/share/runtime/os.cpp line 1346:
>> 
>>> 1344: #ifndef PRODUCT
>>> 1345:     // corruption or uninitialized access pattern
>>> 1346:     const intptr_t pat = 0xabababababababab;
>> 
>> How about constructing this from `badResourceValue`?
>
> We could also put another variable centrally next to badResourceValue , see 
> https://github.com/openjdk/jdk/blob/4fc6d4135e795d18a024a6035908f380b81082d1/src/hotspot/share/utilities/globalDefinitions.hpp#L1044
> do you have a good naming for this ? Maybe `badZapValue` ?

Maybe badResourceValueWord?  But I would put it in os.cpp instead of globalDefinitions.hpp until there are other clients.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21811#discussion_r1830348851