RFR: 8343600: RISC-V: enable CRC32 intrinsic when either Zba or RVV are supported
Fei Yang
fyang at openjdk.org
Wed Nov 6 10:01:30 UTC 2024
On Tue, 5 Nov 2024 09:44:21 GMT, Hamlin Li <mli at openjdk.org> wrote:
> Hi,
> Can you help to review this patch?
>
> There were 2 intrinsic optimizations, scalar one and vector one,
> * plain scalar one optimizes cases when data size is small, scalar one with zba optimizes cases when data size is big;
> * vector one optimizes cases when data size is big (better than scalar one with zba).
>
> With RVV supported, when the size is small it will go to scalar code path, when the size is big it will go to RVV path then scalar path, so that means the RVV itself are sufficient enough to enable the intrinsic even without Zba supported.
>
> Thanks!
Looks fine to me. The dependence on Zba should be a separate issue. Thanks.
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21897#pullrequestreview-2417753424
More information about the hotspot-dev
mailing list