RFR: 8342818: Implement CPU Time Profiling for JFR [v10]

Erik Gahlin egahlin at openjdk.org
Wed Nov 6 12:59:41 UTC 2024


On Wed, 6 Nov 2024 11:00:25 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>>> The problem is, is that `eventType.hasStackTrace()` checks for the existence of a field called `stackTrace`, which CPUTimeSample events have. We could of course rename the field to something like `recordedStackTrace`, but I don't think that this is helpful.
>> 
>> Aha - so even if the event is not decorated with stackTrace=true in metadata.xml, it has an explicit field with the same name "StackTrace". Wonder why this should be handled differently from ExecutionSample?
>
>> Aha - so even if the event is not decorated with stackTrace=true in metadata.xml, it has an explicit field with the same name "StackTrace".
> 
> Yes.
> 
>> Wonder why this should be handled differently from ExecutionSample?
> 
> You're not the only one. I'm looking into it today.

Could it be that the ExecutionSample is a periodic event, CPUTimeSample is not.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1830972453


More information about the hotspot-dev mailing list