RFR: 8342893: Highlight special values in hserr file printing [v2]

Matthias Baesken mbaesken at openjdk.org
Wed Nov 6 15:57:29 UTC 2024


On Wed, 6 Nov 2024 03:40:48 GMT, Dean Long <dlong at openjdk.org> wrote:

>> We could also put another variable centrally next to badResourceValue , see 
>> https://github.com/openjdk/jdk/blob/4fc6d4135e795d18a024a6035908f380b81082d1/src/hotspot/share/utilities/globalDefinitions.hpp#L1044
>> do you have a good naming for this ? Maybe `badZapValue` ?
>
> Maybe badResourceValueWord?  But I would put it in os.cpp instead of globalDefinitions.hpp until there are other clients.

Sounds good , let's use this naming !

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21811#discussion_r1831288927


More information about the hotspot-dev mailing list