RFR: 8342818: Implement CPU Time Profiling for JFR [v10]

Johannes Bechberger jbechberger at openjdk.org
Wed Nov 6 20:52:57 UTC 2024


On Wed, 6 Nov 2024 18:58:44 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Only do timer init and removal at global safepoint
>>  - Only do timer init and removal at global safepoint
>
> src/hotspot/share/jfr/recorder/storage/jfrMemorySpaceRetrieval.hpp line 88:
> 
>> 86:       if (node == nullptr) return nullptr;
>> 87:       assert(node->free_size() >= size, "invariant");
>> 88:       assert(node->identity() == nullptr, "invariant");
> 
> This is not the right way to do it.

Good catch, I removed it during debugging.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1831691709


More information about the hotspot-dev mailing list