RFR: 8343317: Extend test generation tool to handle APX NDD/NF flavor of instructions [v5]
Srinivas Vamsi Parasa
sparasa at openjdk.org
Wed Nov 6 23:33:43 UTC 2024
On Wed, 6 Nov 2024 17:56:08 GMT, hanklo6 <duke at openjdk.org> wrote:
>> Extend test generation tool and gtest (added as part of https://bugs.openjdk.org/browse/JDK-8339507) to handle Intel APX NDD/NF instructions.
>>
>> Intel Advanced Performance Extensions (APX) adds non destructive destination (NDD) and no flags (NF) flavor for the scalar instructions through EVEX encoding. For more information about APX, see https://www.intel.com/content/www/us/en/developer/articles/technical/advanced-performance-extensions-apx.html.
>
> hanklo6 has updated the pull request incrementally with one additional commit since the last revision:
>
> Align output in assembler test
This PR looks good to me.
Also, I Independently tested that this tool works (i.e. all the tests are passing) after pulling in the APX encoding bugfix (https://github.com/openjdk/jdk/pull/21770) changes recently integrated into OpenJDK.
Thanks,
Srinivas Vamsi Parasa (from Intel)
-------------
Marked as reviewed by sparasa (Author).
PR Review: https://git.openjdk.org/jdk/pull/21795#pullrequestreview-2419646377
More information about the hotspot-dev
mailing list