Integrated: 8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

theoweidmannoracle duke at openjdk.org
Thu Nov 7 07:50:49 UTC 2024


On Tue, 5 Nov 2024 12:21:58 GMT, theoweidmannoracle <duke at openjdk.org> wrote:

> From JBS:
> 
>> HotSpot VM build macro defines _WINDOWS env variable only.
>> call_clobbered_gp_registers() and call_clobbered_xmm_registers() incorrectly use WINDOWS (without underscore).
>> RSI and RDI are missing from list of clobbered register on windows due to that and may cause issue when calling native code which modifies them.
>> 
>> AMM register are less affected because all XMM registers are listed as clobbered.
>> 
>> The code was added by [JDK-8283327](https://bugs.openjdk.org/browse/JDK-8283327) changes in JDK 19.

This pull request has now been integrated.

Changeset: 0e1c1b79
Author:    theoweidmannoracle <theo.weidmann at oracle.com>
Committer: Christian Hagedorn <chagedorn at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/0e1c1b793d43064aabe9571057284899c9580f30
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

8343452: Incorrect WINDOWS build variable is used in macroAssembler_x86.cpp

Reviewed-by: kvn, chagedorn, jwaters

-------------

PR: https://git.openjdk.org/jdk/pull/21901


More information about the hotspot-dev mailing list