RFR: 8342818: Implement CPU Time Profiling for JFR [v17]

[Matthias Baesken]

On Thu, 7 Nov 2024 15:11:00 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:

>> This is the code for the [JEP draft: CPU Time based profiling for JFR].
>
> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Don't treat stackTrace attribute specially for CPUTimeSamples

src/hotspot/share/jfr/metadata/metadata.xml line 940:

> 938: 
> 939:   <Event name="CPUTimeSample" category="Java Virtual Machine, Profiling" label="CPU Time Method Sample"
> 940:     description="Snapshot of a threads state from the CPU time sampler. The throttle can be either an upper bound for the event emission rate, e.g. 100/s, or the cpu-time period, e.g. 10ms, with s, ms, us and ns supported as time units."

The throttle  event setting is 'true' (boolean) by default; but then you speak about that it is some time unit like 10ms.  Maybe the description might need a bit of adjustment to make it more clear to the average JFR user what it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1832872474