RFR: 8342818: Implement CPU Time Profiling for JFR [v17]

Johannes Bechberger jbechberger at openjdk.org
Thu Nov 7 15:32:05 UTC 2024


On Thu, 7 Nov 2024 15:23:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Don't treat stackTrace attribute specially for CPUTimeSamples
>
> src/hotspot/share/jfr/metadata/metadata.xml line 940:
> 
>> 938: 
>> 939:   <Event name="CPUTimeSample" category="Java Virtual Machine, Profiling" label="CPU Time Method Sample"
>> 940:     description="Snapshot of a threads state from the CPU time sampler. The throttle can be either an upper bound for the event emission rate, e.g. 100/s, or the cpu-time period, e.g. 10ms, with s, ms, us and ns supported as time units."
> 
> The throttle  event setting is 'true' (boolean) by default; but then you speak about that it is some time unit like 10ms.  Maybe the description might need a bit of adjustment to make it more clear to the average JFR user what it is.

`throttle=true` means that this event has a throttle attribute, that should be clear to the user.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1832882472


More information about the hotspot-dev mailing list