RFR: 8327156: Avoid copying in StringTable::intern(oop, TRAPS) [v6]

[Julian Waters]

On Mon, 11 Nov 2024 21:52:42 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Casper Norrbin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   size moved to wrapper
>
> src/hotspot/share/classfile/stringTable.cpp line 153:
> 
>> 151: }
>> 152: 
>> 153: bool StringTable::wrapped_string_equals(oop java_string, StringWrapper wrapped_str, int _) {
> 
> Not sure what hotspot style rules are for unused parameters. Probably worth a comment as to why this unused parameter exists.

A quick search of the Style Guide yields nothing. I'd prefer the existing name be kept, but if it really shouldn't be used, then an unnamed parameter will suffice, no need for giving it _ as a name

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21325#discussion_r1837433599