RFR: 8338007: [JVMCI] ResolvedJavaMethod.reprofile can crash ciMethodData [v3]

Tom Rodriguez never at openjdk.org
Tue Nov 12 15:55:52 UTC 2024


On Fri, 8 Nov 2024 16:44:01 GMT, Tom Rodriguez <never at openjdk.org> wrote:

>> Graal unit testing uses ResolvedJavaMethod.reprofile to reset profiles between test but the current code rewrites the layout in a non-atomic way which can break other readers.  Instead perform the reinitialization at a safepoint which should protect all readers from seeing any transient initialization states.
>
> Tom Rodriguez has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into tkr-mdo-reinitialize
>  - Review comments
>  - 8338007: [JVMCI] ResolvedJavaMethod.reprofile can crash ciMethodData

The automatic check failure seems to be a configuration problem with macos so that looks good.  I reran the mach5 testing against latest master so it all looks good.  Thanks for the reviews.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21746#issuecomment-2470900370


More information about the hotspot-dev mailing list