RFR: 8343430: RISC-V: C2: Remove old trampoline call [v8]

Hamlin Li mli at openjdk.org
Tue Nov 12 18:16:18 UTC 2024


On Tue, 12 Nov 2024 15:39:05 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hi, please consider this cleanup change.
>> 
>> The old trampoline call on linux-riscv64 is disabled by default after: https://bugs.openjdk.org/browse/JDK-8332689.
>> And the new solution (load target address from stub and call) has been baked in jdk master for quite some time.
>> This propose to remove the old trampoline call related logic so that the code will be cleaner and easier to maintain.
>> As we are still using `trampoline_stub_Relocation` for the stub, I kept using the original `emit_trampoline_stub` name.
>> 
>> Testing on linux-riscv64:
>> - [x] tier1-tier3 (release)
>> - [x] hotspot:tier1 (fastdebug)
>
> Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8343430
>  - More Comments
>  - Merge remote-tracking branch 'upstream/master' into JDK-8343430
>  - More naming
>  - More improvements
>  - Minor
>  - More comments
>  - Comment
>  - Improve
>  - Code comment
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/2989d873...11442458

Still good, Thanks!

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21822#pullrequestreview-2430360416


More information about the hotspot-dev mailing list