RFR: 8342818: Implement CPU Time Profiling for JFR [v21]

Wed Nov 13 09:21:59 UTC 2024

On Wed, 13 Nov 2024 09:00:59 GMT, Jaroslav Bachorik <jbachorik at openjdk.org> wrote:

>> Johannes Bechberger has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make parsing rates safer
>
> src/hotspot/share/jfr/recorder/stacktrace/jfrAsyncStackTrace.cpp line 68:
> 
>> 66:   _reached_root = true;
>> 67: 
>> 68:   JfrVframeStream vfs(jt, frame, false, true, false);
> 
> Does this mean we are not going to get frames from virtual threads/continuations?

Only the ones that are currently on the stack, as far as I understand.

But this change is required, as walking continuations in a signal causes crashes.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1839799573