RFR: 8343756: CAN_SHOW_REGISTERS_ON_ASSERT for Windows [v3]

[Thomas Stuefe]

On Wed, 13 Nov 2024 23:35:22 GMT, Markus Grönlund <mgronlun at openjdk.org> wrote:

>> Greetings,
>> 
>> This enhancement adds register printouts on asserts or guarantees into the hs_err_pid.log error reporting files for Windows.
>> 
>> Additionally, it saves an accurate EXCEPTION_RECORD into the  hs_err_pid.mdmp file, also for asserts or guarantees, so the assertion context is now easily accessible in Windbg using .ecxr.
>> 
>> For more details on this enhancement, please see the JIRA issue.
>> 
>> Testing: Tier 1,2,3, jdk_jfr
>> 
>> Thanks
>> Markus
>
> Markus Grönlund has updated the pull request incrementally with one additional commit since the last revision:
> 
>   refactor into VMError::was_assert_poison_crash

Looks good.

Would it be possible for you to extend the test a bit, at least for x64, to test for registers to have appeared? E.g. RIP or RAX.

-------------

PR Review: https://git.openjdk.org/jdk/pull/21994#pullrequestreview-2435209337