RFR: 8327156: Avoid copying in StringTable::intern(oop, TRAPS) [v11]

Casper Norrbin cnorrbin at openjdk.org
Thu Nov 14 10:00:37 UTC 2024


On Wed, 13 Nov 2024 16:29:09 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed whitespace
>
> src/hotspot/share/classfile/stringTable.hpp line 69:
> 
>> 67:   static unsigned int hash_wrapped_string(StringWrapper& wrapped_str);
>> 68:   static const jchar* to_unicode(StringWrapper& wrapped_str, int &len, TRAPS);
>> 69:   static Handle handle_from_wrapped_string(StringWrapper& wrapped_str, TRAPS);
> 
> One last thing, should the be const references?

You're right, fixed now!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21325#discussion_r1841903339


More information about the hotspot-dev mailing list