RFR: 8342818: Implement CPU Time Profiling for JFR [v21]
Jaroslav Bachorik
jbachorik at openjdk.org
Thu Nov 14 17:42:38 UTC 2024
On Wed, 13 Nov 2024 09:11:46 GMT, Johannes Bechberger <jbechberger at openjdk.org> wrote:
>> src/hotspot/share/jfr/recorder/stacktrace/jfrAsyncStackTrace.cpp line 68:
>>
>>> 66: _reached_root = true;
>>> 67:
>>> 68: JfrVframeStream vfs(jt, frame, false, true, false);
>>
>> Does this mean we are not going to get frames from virtual threads/continuations?
>
> Only the ones that are currently on the stack, as far as I understand.
>
> But this change is required, as walking continuations in a signal causes crashes.
Ok. This is benign then. Since the carrier thread is being executed the virtual thread frames (if any is mounted) will be on stack.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20752#discussion_r1842644581
More information about the hotspot-dev
mailing list