RFR: 8343541: C1: Plain memory accesses are emitted with membars with +AlwaysAtomicAccesses [v2]

Xiaolong Peng xpeng at openjdk.org
Mon Nov 18 09:30:55 UTC 2024


On Mon, 18 Nov 2024 09:16:05 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Xiaolong Peng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   renaming
>
> src/hotspot/share/gc/shared/c1/barrierSetC1.cpp line 144:
> 
>> 142:   DecoratorSet decorators = access.decorators();
>> 143:   bool is_volatile = (decorators & MO_SEQ_CST) != 0;
>> 144:   bool is_atomic_access = is_volatile || AlwaysAtomicAccesses;
> 
> Can be just `is_atomic`, I think.

Thanks, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22191#discussion_r1846164694


More information about the hotspot-dev mailing list