RFR: 8344381: [s390x] Test failures with error: Register type is not known

Martin Doerr mdoerr at openjdk.org
Mon Nov 18 13:27:57 UTC 2024


On Mon, 18 Nov 2024 10:17:12 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> Adds SaveLiveRegister portion for vector registers also. 
> 
> Depends on https://github.com/openjdk/jdk/pull/22190. Once that PR gets integrated, will rebase and mark it ready for review.

Looks basically good. I think that the instructions can encode the maximum frame size.

src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp line 280:

> 278:         }
> 279:       }
> 280:     } else if (vm_reg->is_VectorRegister()){

There should be a space before `{`.

src/hotspot/cpu/s390/gc/shared/barrierSetAssembler_s390.cpp line 284:

> 282:       if (vs_reg->encoding() >= Z_V2->encoding() && vs_reg->encoding() <= Z_V31->encoding()) {
> 283:         reg_save_index += 2;
> 284:         Register spill_addr = Z_R0;

Unused.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22197#pullrequestreview-2442600844
PR Review Comment: https://git.openjdk.org/jdk/pull/22197#discussion_r1846572377
PR Review Comment: https://git.openjdk.org/jdk/pull/22197#discussion_r1846572890


More information about the hotspot-dev mailing list