RFR: 8344381: [s390x] Test failures with error: Register type is not known [v2]
Martin Doerr
mdoerr at openjdk.org
Tue Nov 19 05:24:26 UTC 2024
On Mon, 18 Nov 2024 13:32:59 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> Adds SaveLiveRegister portion for vector registers also.
>>
>> Depends on https://github.com/openjdk/jdk/pull/22190. Once that PR gets integrated, will rebase and mark it ready for review.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>
> suggestion from martin
This makes sense. Only volatile registers which are allocated need to be saved and restored. You could also use `is_volatile()` functions from the `Register` class.
The registers which are not allocated should not show up here because we get them from `live_regs_iterator.next()`. So, I think there's no need to filter them out. But you can filter them out. I have no objects. I had basically asked because of readability reasons. Sorry if my question was a bit confusing.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/22197#issuecomment-2484150790
More information about the hotspot-dev
mailing list