RFR: 8344393: RISC-V: Remove option UseRVVForBigIntegerShiftIntrinsics [v2]

Hamlin Li mli at openjdk.org
Tue Nov 19 09:46:45 UTC 2024


On Tue, 19 Nov 2024 00:24:14 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Seem that it's more reasonable to control BigInteger shift intrinsics with`UseRVV` option.
>> I witnessed performance benefit on BPI-F3 with the RISC-V vector extension. And it's still
>> possible to disable these two intrinsics with `-XX:DisableIntrinsic` option if we want.
>> 
>> JMH on BPI-F3 (has vector 1.0) for reference:
>> 
>> Without instrinsic:
>> BigIntegers.testLeftShift                        N/A  avgt   15      4083.865 ±   224.139  ns/op
>> BigIntegers.testRightShift                       N/A  avgt   15      1745.833 ±    44.855  ns/op
>> 
>> With instrinsic:
>> BigIntegers.testLeftShift                        N/A  avgt   15      2243.095 ±    24.821  ns/op
>> BigIntegers.testRightShift                       N/A  avgt   15      1558.770 ±    36.191  ns/op
>> 
>> 
>> Test on linux-riscv64 platform:
>> - [x] tier1 (release)
>
> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove jvmci use cases

Still good. Thanks!

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22202#pullrequestreview-2444891588


More information about the hotspot-dev mailing list