RFR: 8335367: [s390] Add support for load immediate on condition instructions.

[Amit Kumar]

On Wed, 13 Nov 2024 06:16:23 GMT, Manjunath S Matti. <duke at openjdk.org> wrote:

> Add support for load immediate on condition instructions.

minor nits to do, otherwise looks good.

src/hotspot/cpu/s390/assembler_s390.hpp line 2076:

> 2074:   inline void z_lochi(Register r1, int64_t i2, branch_condition m3);   // load immediate r1[32-64] = i2_imm16   ; int32 <- int16
> 2075:   inline void z_lochhi(Register r1, int64_t i2, branch_condition m3);  // load immediate r1[ 0-31] = i2_imm16   ; int32 <- int16
> 2076:   inline void z_locghi(Register r1, int64_t i2, branch_condition m3);  // load immediate r1[ 0-63] = i2_imm16   ; int64 <- int16

Suggestion:

  inline void z_lochi(Register r1, int64_t i2, branch_condition m3);   // load immediate r1[32-63] = i2_simm16   ; int32 <- int16
  inline void z_lochhi(Register r1, int64_t i2, branch_condition m3);  // load immediate r1[ 0-31] = i2_simm16   ; int32 <- int16
  inline void z_locghi(Register r1, int64_t i2, branch_condition m3);  // load immediate r1[ 0-63] = i2_simm16   ; int64 <- int16

-------------

Changes requested by amitkumar (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22058#pullrequestreview-2445183949
PR Review Comment: https://git.openjdk.org/jdk/pull/22058#discussion_r1848184321