RFR: 8344445: MethodCounters don't need a vptr [v2]
Coleen Phillimore
coleenp at openjdk.org
Tue Nov 19 12:23:09 UTC 2024
On Tue, 19 Nov 2024 08:12:22 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove method_pointers_size() in favor of static size().
>
> src/hotspot/share/oops/methodCounters.hpp line 66:
>
>> 64: return align_up((int)sizeof(MethodCounters), wordSize) / wordSize;
>> 65: }
>> 66: int size() const {
>
> size() could be static (MetaspaceObj description allows this), with method_counters_size impl moved
> here. Then remove method_counters_size and update the two calls to MethodCounters::size().
Thanks - this is a nice cleanup.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22220#discussion_r1848249238
More information about the hotspot-dev
mailing list