RFR: 8344381: [s390x] Test failures with error: Register type is not known [v3]
Martin Doerr
mdoerr at openjdk.org
Tue Nov 19 12:57:44 UTC 2024
On Tue, 19 Nov 2024 05:24:26 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> Adds SaveLiveRegister portion for vector registers also.
>>
>> Depends on https://github.com/openjdk/jdk/pull/22190. Once that PR gets integrated, will rebase and mark it ready for review.
>
> Amit Kumar has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Merge branch 'master' into v_test_failure_v0
> - additional changes
> - suggestion from martin
> - no more ignoring vector registers
>
> fix'
Looks correct to me. I would probably not exclude F1. But if the decision not to use it for allocation is fixed, ok. @RealLucy: Please take a 2nd look.
-------------
Marked as reviewed by mdoerr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22197#pullrequestreview-2445392827
More information about the hotspot-dev
mailing list