RFR: 8329351: Add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing

Coleen Phillimore coleenp at openjdk.org
Tue Nov 19 17:08:51 UTC 2024


On Tue, 19 Nov 2024 13:09:22 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

> @dcubed-ojdk is too busy, so I was asked to take over [https://github.com/openjdk/jdk/pull/18664](https://github.com/openjdk/jdk/pull/18664) and finish it.
> 
> That old PR contains all the details and also got some review comments, which I have tried to address in this new PR.
> 
> Tests run without failures on supported platforms.

Thank you for taking over this work. We've found this test to be really valuable, so good to have in our test system even if it functionally overlaps with other tests.  See two questions.

test/hotspot/jtreg/TEST.groups line 604:

> 602:  -runtime/CompressedOops/UseCompressedOops.java \
> 603:  -runtime/InvocationTests \
> 604:  -runtime/Monitor/StressWrapper_TestRecursiveLocking_36M.java \

Does runtime/Monitor/TestRecursiveLocking.java need to be added in here too?

test/hotspot/jtreg/runtime/Monitor/TestRecursiveLocking.java line 465:

> 463:                 syncObj.runAlternateABTest();
> 464:                 break;
> 465: 

I was wondering if this test could be reduced to run both modes  in one execution, one after the other?

-------------

PR Review: https://git.openjdk.org/jdk/pull/22238#pullrequestreview-2446093004
PR Review Comment: https://git.openjdk.org/jdk/pull/22238#discussion_r1848739091
PR Review Comment: https://git.openjdk.org/jdk/pull/22238#discussion_r1848738342


More information about the hotspot-dev mailing list