RFR: 8318098: Update jfr tests with corresponding requires flags [v2]

[Markus Grönlund]

On Tue, 19 Nov 2024 17:09:00 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> There are few JFR tests are failing with -Xcomp and compiler stress flags. 
>> I added requires tag when tests are incompatible with corresponding mode:
>> 1) huge stacks and DeoptimieALot cause timeout
>> 2) WB controlled compilation doesn't work with Xcomp
>> 3) Arguments tests might be sensitive to aby flags and should be flagless
>> and excluded a 2 groups of tests failing with Xcomp for further invesitigation.
>> 
>> The drivers for these are following bug escapes because of JFR was not tested with VM flags:
>> https://bugs.openjdk.org/browse/JDK-8340586
>> https://bugs.openjdk.org/browse/JDK-8344199
>> https://bugs.openjdk.org/browse/JDK-8340826
>> https://bugs.openjdk.org/browse/JDK-8343893
>> 
>> 
>> So now jfr tests support all flags used for testing  in CI with them.
>> The bug
>> https://bugs.openjdk.org/browse/JDK-8318098
>> has a linked all the product issues found by running JFR tests with flags and explanation why is it needed.
>
> Leonid Mesnik has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
> 
>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8318098
>  - 8318098: Update jfr tests with corresponding requires flags
>  - Merge branch 'master' of https://github.com/lmesnik/jdk
>  - 8344051

The intent of all JFR tests was NOT to run in every kind of conceivable combination.

That was the whole purpose of the jfr jtreg keyword, when we introduced it: to not accept outside parameters.

Our tests are unit tests carefully designed to test a specific part of JFR. They are not integration tests and may not work under all compiler and GC combinations.

It has been this way for over 10 years - why is this changing now?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22249#issuecomment-2486339277