RFR: 8339134: Callers of Exceptions::fthrow should ensure exception message lengths avoid the INT_MAX limits of os::vsnprintf [v2]

[Coleen Phillimore]

On Mon, 4 Nov 2024 09:02:10 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> This is mostly an audit of the callers of `Exceptions::fthrow` to ensure unbounded strings can't appear.
>> 
>> There is a code change in DiagnosticCmd parsing to extend the string length limit already used in part of that code.
>> 
>> Testing:
>>  - tier 1-3 (sanity)
>> 
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Restore previous behaviour for zero length strings

Okay, I understand the change now.  Looks good.

src/hotspot/share/interpreter/linkResolver.cpp line 328:

> 326: 
> 327:     // Names are all known to be < 64k so we know this formatted message is not excessively large.
> 328: 

Can you move this comment to before the first fthrow call at 331?  The other fthrow has a msg so doesn't really apply and the comment looks better as just one line like the other places.

-------------

Marked as reviewed by coleenp (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21867#pullrequestreview-2446760257
PR Review Comment: https://git.openjdk.org/jdk/pull/21867#discussion_r1849122316