RFR: 8342769: HotSpot Windows/gcc port is broken [v4]
Julian Waters
jwaters at openjdk.org
Wed Nov 20 08:52:41 UTC 2024
> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
- size_t brace initialization instead of unsigned literals in test_os_windows.cpp
- size_t brace initialization instead of unsigned literal in test_os.cpp
- Check for _M_ARM64 instead of _WIN64 in sharedRuntime.cpp
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/21627/files
- new: https://git.openjdk.org/jdk/pull/21627/files/fb171a43..47810433
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=21627&range=03
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=21627&range=02-03
Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod
Patch: https://git.openjdk.org/jdk/pull/21627.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/21627/head:pull/21627
PR: https://git.openjdk.org/jdk/pull/21627
More information about the hotspot-dev
mailing list