RFR: 8342769: HotSpot Windows/gcc port is broken [v4]

Andrew Haley aph at openjdk.org
Wed Nov 20 09:07:17 UTC 2024


On Wed, 20 Nov 2024 08:52:41 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - size_t brace initialization instead of unsigned literals in test_os_windows.cpp
>  - size_t brace initialization instead of unsigned literal in test_os.cpp
>  - Check for _M_ARM64 instead of _WIN64 in sharedRuntime.cpp

Wouldn't it be far easier to handle `fmod` ourselves in the AArch64b back end?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21627#issuecomment-2487957083


More information about the hotspot-dev mailing list