RFR: 8342769: HotSpot Windows/gcc port is broken [v4]

[Julian Waters]

On Wed, 20 Nov 2024 12:17:30 GMT, Andrew Haley <aph at openjdk.org> wrote:

> > > > Wouldn't it be far easier to handle `fmod` ourselves in the AArch64b back end?
> > > 
> > > 
> > > You mean like how x86 has its own custom fmod implementation in the assembler? That does sound pretty good to me, then we could get rid of this workaround entirely, but I don't know how to implement this on ARM64
> > 
> > 
> > Oh, OK. I'll have a look.
> 
> I had a look at SharedRuntime::fmod_winx64. I'm sure it's fine for AArch64. Just put it in os_windows.

I'm not sure I understand - The fix in this Pull Request already uses SharedRuntime::fmod_winx64 (Or more accurately, it doesn't change the existing code that uses it, just makes the ifdef check more accurate). I don't know if moving the implementation from sharedRuntimeRem.cpp to os_windows.cpp gives any benefit, and sharedRuntimeRem.cpp is already under os/windows. I might have misunderstood you earlier, but it sounded as if you were proposing to implement frem and drem in assembly for ARM64 like what is already done for x86

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21627#issuecomment-2488663492