RFR: 8329351: Add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing [v3]
Fredrik Bredberg
fbredberg at openjdk.org
Wed Nov 20 17:24:17 UTC 2024
On Wed, 20 Nov 2024 16:23:28 GMT, Daniel D. Daugherty <dcubed at openjdk.org> wrote:
>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> s/removed/removes/
>
> test/hotspot/jtreg/runtime/Monitor/TestRecursiveLocking.java line 439:
>
>> 437: System.err.println("ERROR: '" + argv[1]
>> 438: + "': invalid mode value.");
>> 439: usage(mode, n_secs);
>
> Please drop these parameters.
>
> The reason for adding `def_mode` and `def_n_secs` above is that when this `usage()` call
> is made, it will print the current `n_secs` value instead of the actual default `n_secs` value.
> It will also print the `mode` value returned by L429 instead of the actual default `mode` value.
My bad. I was a bit too quick.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22238#discussion_r1850717286
More information about the hotspot-dev
mailing list