RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations
Amit Kumar
amitkumar at openjdk.org
Thu Nov 21 04:59:18 UTC 2024
On Wed, 20 Nov 2024 15:24:24 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> Implementation of JDK-8343767
>
> This PR is now ready for review. I'd be grateful if owners of riscv, ppc, s390 and arm ports could ensure that it passes tests on those platforms -- I don't have the kit to do so.
>
> I also noticed 2 failures on macos/x64. They are both CodeBuffer validation errors:
>
> # Internal Error (codeBuffer.cpp:1004), pid=33878, tid=28419
> # guarantee(sect->end() <= tend) failed: sanity
>
> I'm not sure how they relate to this change but I can see that they might be to do with changing the blob names or some inadvertent change to the blob sizes. Unfortunately, I am not able to reproduce them as I don't have the relevant kit.
@adinn I think there is some issue with s390x. With current changes I got build failure:
Error occurred during initialization of boot layer
java.lang.moduleºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾
Caused by: jaº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾
gmake[3]: *** [Gendata.gmk:64: /home/amit/jdk/build/linux-s390x-server-fastdebug/buildtools/create_symbols_javac/_the.COMPILE_CREATE_SYMBOLS_batch] Error 1
gmake[2]: *** [make/Main.gmk:139: jdk.compiler-gendata] Error 2
gmake[2]: *** Waiting for unfinished jobs....
ERROR: Build failed for target 'images' in configuration 'linux-s390x-server-fastdebug' (exit code 2)
Stopping javac server
=== Output from failing command(s) repeated here ===
* For target buildtools_create_symbols_javac__the.COMPILE_CREATE_SYMBOLS_batch:
Error occurred during initialization of boot layer
java.lang.moduleºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾
Caused by: jaº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾ºº¾
* All command lines available in /home/amit/jdk/build/linux-s390x-server-fastdebug/make-support/failure-logs.
=== End of repeated output ===
Though I don't see any command it ran before running into this failure.
without your commits, i.e. on commit `235973615fbad7073df67167ab1cb4d40b6f1ab5` build is fine.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21957#issuecomment-2490080596
More information about the hotspot-dev
mailing list