RFR: 8344140: Refactor the discovery of AOT cache artifacts
Ioi Lam
iklam at openjdk.org
Thu Nov 21 05:32:54 UTC 2024
This is a clean up after the initial integration for [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737)
- Merged 3 loops into 1 for discovering the classes and oops that should be stored in the AOT cache. About 250 lines of code are deleted.
- Added comments in aotArtifactFinder.hpp to describe the logic, which is much simpler than before.
- Enum classes are no longer unconditionally AOT-initialized -- an Enum class is AOT-initialized only if we find an archived oop of this type.
Note to reviewers:
One consequence of this refactoring is that archived oops are now discovered (by heapShared.cpp) before the metadata are copied (by ArchiveBuilder). There are some functions that depend on the old order (metadata were copied before oop discovery), so I had to shuffle them around. Examples are `Modules::check_archived_module_oop()`, or the new code in `Klass::remove_java_mirror()`.
-------------
Commit messages:
- more clean up
- tmp
- More clean up
- Removed unnecessary code
- 8344140: Consolidate AOT cache code for artifact discovery
Changes: https://git.openjdk.org/jdk/pull/22291/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22291&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8344140
Stats: 1301 lines in 29 files changed: 535 ins; 659 del; 107 mod
Patch: https://git.openjdk.org/jdk/pull/22291.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22291/head:pull/22291
PR: https://git.openjdk.org/jdk/pull/22291
More information about the hotspot-dev
mailing list