RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v2]

[David Holmes]

On Wed, 20 Nov 2024 22:02:34 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Currently, when retrieving a ClassFileStream during runtime, we call into the zip library to retrieve the stream based only on a class name. This doesn't work well if the class is in a multi-release jar under a versioned directory such as `META-INF/versions/9/Foo.class`. To address this issue, this change calls the java api `ClassLoader.getResourceAsStream()` to retrieve the stream.
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   updated testcase

test/hotspot/jtreg/runtime/cds/appcds/jvmti/CFLH/MultiReleaseJars.java line 48:

> 46:     static final String MAJOR_VERSION_STRING = String.valueOf(MAJOR_VERSION);
> 47: 
> 48:     static String[] getMain() {

Can't you just define these as source files in the test directory rather than creating them dynamically?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22262#discussion_r1851413967