RFR: 8342769: HotSpot Windows/gcc port is broken [v6]

Andrew Haley aph at openjdk.org
Thu Nov 21 10:10:25 UTC 2024


On Thu, 21 Nov 2024 06:41:33 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely
>
> Julian Waters has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Revise comment in sharedRuntime.hpp

src/hotspot/share/runtime/sharedRuntime.hpp line 149:

> 147:   // now needs the workaround, so this is now used
> 148:   // for Windows ARM64
> 149:   static double fmod_winx64(double x, double y);

Suggestion:

  static double fmod_win64(double x, double y);

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21627#discussion_r1851740250


More information about the hotspot-dev mailing list