RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations [v2]

[Andrew Dinn]

On Thu, 21 Nov 2024 07:21:48 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   fix comments and remove unused stubid on riscv
>
> src/hotspot/cpu/riscv/stubDeclarations_riscv.hpp line 37:
> 
>> 35:   do_arch_entry(riscv, initial, get_previous_sp,                        \
>> 36:                 get_previous_sp_entry,                                  \
>> 37:                 get_previous_sp_entry)                                  \
> 
> `get_previous_sp_entry` has been removed by https://bugs.openjdk.org/browse/JDK-8344265.

Thanks for spotting this. I missed it when reconciling against your deletion. I think I got lal the others though.

Fixed in latest push.

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 1117:
> 
>> 1115:   //   used by generate_conjoint_int_oop_copy().
>> 1116:   //
>> 1117:   address generate_disjoint_copy(StubGenStubId stub_id, address* entry) {
> 
> Preceding code comment needs update to reflect the new parameters.

Fixed in latest push

> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 1265:
> 
>> 1263:   // cache line boundaries will still be loaded and stored atomically.
>> 1264:   //
>> 1265:   address generate_conjoint_copy(StubGenStubId stub_id, address nooverlap_target, address *entry) {
> 
> Preceding code comment needs update to reflect the new parameters.

Fixed in latest push

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1851831650
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1851829018
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1851829441