RFR: 8329351: Add runtime/Monitor/TestRecursiveLocking.java for recursive Java monitor stress testing [v4]
Coleen Phillimore
coleenp at openjdk.org
Thu Nov 21 12:02:21 UTC 2024
On Thu, 21 Nov 2024 09:59:06 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:
>> test/hotspot/jtreg/runtime/Monitor/StressWrapper_TestRecursiveLocking_36M.java line 1:
>>
>>> 1: /*
>>
>> What does the `36M` signify? Do we really need it? Could we not just call this `StressTestRecursiveLocking`?
>
> From [JDK-8329351](https://bugs.openjdk.org/browse/JDK-8329351): _"`.../StressWrapper_TestRecursiveLocking_36M.java` is a wrapper that executes `.../TestRecursiveLocking.java` for 2 minutes for each of the 18 configs for a total of 36 minutes of execution time..."_
>
> I think there is some value in looking at a test file's name, and thereby know how long it will take to run.
>
> @dcubed-ojdk created and named the file, maybe he has an opinion.
There's precedent for this naming in our internal tests (runthese and kitchensink).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22238#discussion_r1851925495
More information about the hotspot-dev
mailing list