RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations [v2]

[Andrew Dinn]

On Thu, 21 Nov 2024 10:58:34 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Implementation of JDK-8343767
>
> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix comments and remove unused stubid on riscv

src/hotspot/cpu/s390/stubGenerator_s390.cpp line 630:

> 628: 
> 629:   address generate_lookup_secondary_supers_table_stub(u1 super_klass_index) {
> 630:     StubGenStubId stub_id = (StubGenStubId)(StubGenStubId::partial_subtype_check_id + super_klass_index);

@offamitkumar This is clearly a cut and paste error. The base id for the stub should be lookup_secondary_supers_table_id i.e. the above line should be:

StubGenStubId stub_id = (StubGenStubId)(StubGenStubId::lookup_secondary_supers_table_id + super_klass_index);

src/hotspot/cpu/s390/stubGenerator_s390.cpp line 1279:

> 1277:       break;
> 1278:     case arrayof_jbyte_disjoint_arraycopy_id:
> 1279:       aligned = false;

This is another cut and paste error. The arrayof stubs are aligned so they should have:
  aligned = true;

src/hotspot/cpu/s390/stubGenerator_s390.cpp line 1373:

> 1371:       break;
> 1372:     case arrayof_jbyte_arraycopy_id:
> 1373:       aligned = false;

Likewise the same error here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1852045544
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1852047973
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1852049094