RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v2]

Calvin Cheung ccheung at openjdk.org
Thu Nov 21 23:14:58 UTC 2024


On Thu, 21 Nov 2024 17:00:47 GMT, Chen Liang <liach at openjdk.org> wrote:

>> test/hotspot/jtreg/runtime/cds/appcds/jvmti/CFLH/MultiReleaseJars.java line 48:
>> 
>>> 46:     static final String MAJOR_VERSION_STRING = String.valueOf(MAJOR_VERSION);
>>> 47: 
>>> 48:     static String[] getMain() {
>> 
>> Can't you just define these as source files in the test directory rather than creating them dynamically?
>
> I think the concern may be that we want to avoid license headers.
> 
> However, we should still use text blocks instead of these string arrays for such inlined source files.

I've changed the code to use text blocks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22262#discussion_r1853068142


More information about the hotspot-dev mailing list