RFR: 8342769: HotSpot Windows/gcc port is broken [v9]

Julian Waters jwaters at openjdk.org
Fri Nov 22 09:17:53 UTC 2024


> Several areas in HotSpot are broken in the gcc port. These, with the exception of 1 rather big oversight within SharedRuntime::frem and SharedRuntime::drem, are all minor correctness issues within the code. These mostly can be fixed with simple changes to the code. Note that I am not sure whether the SharedRuntime::frem and SharedRuntime::drem fix is correct. It may be that they can be removed entirely

Julian Waters has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 16 additional commits since the last revision:

 - Merge branch 'openjdk:master' into hotspot
 - Reintroduce ifdef removed in the nuking of the Windows 32 bit x86 port in sharedRuntimeRem.cpp
 - fmod_win64 in sharedRuntime.cpp
 - Should only declare fmod_win64 on Windows/ARM64 sharedRuntime.hpp
 - fmod_win64 in src/hotspot/share/runtime/sharedRuntime.hpp
   
   Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
 - No spaces in test_os_windows.cpp
 - No spaces in test/hotspot/gtest/runtime/test_os.cpp
   
   Co-authored-by: Andrew Haley <aph-open at littlepinkcloud.com>
 - Revise comment in sharedRuntime.hpp
 - Revise comment in sharedRuntime.cpp
 - size_t brace initialization instead of unsigned literals in test_os_windows.cpp
 - ... and 6 more: https://git.openjdk.org/jdk/compare/f7b5c841...6cf1c83a

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/21627/files
  - new: https://git.openjdk.org/jdk/pull/21627/files/6caa759b..6cf1c83a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=21627&range=08
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=21627&range=07-08

  Stats: 12468 lines in 381 files changed: 4246 ins; 6419 del; 1803 mod
  Patch: https://git.openjdk.org/jdk/pull/21627.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/21627/head:pull/21627

PR: https://git.openjdk.org/jdk/pull/21627


More information about the hotspot-dev mailing list