RFR: 8339983: [s390x] secondary_super_cache does not scale well: C1 and interpreter [v2]

[Amit Kumar]

On Mon, 25 Nov 2024 10:16:03 GMT, Andrew Haley <aph at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggestion from Andrew
>
> src/hotspot/cpu/s390/macroAssembler_s390.cpp line 3178:
> 
>> 3176:   int slots = 0;
>> 3177:   constexpr int NumRegs = 5;
>> 3178:   Register* regs[NumRegs] = {&temp_reg, &temp2_reg, &temp3_reg, &temp4_reg, &result_reg};
> 
> You don't need this array. It contains information that is in `pushed_regs`. Use `pushed_regs.begin()` to create an iterator, which you use like this:
> 
> 
>     int i = 0;
>     for (auto it = pushed_regs.begin(); *it != noreg; ++it, i++) {
>      z_stg(*it++, i * BytesPerWord + frame::z_abi_160_size, Z_SP);
>     }

done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22341#discussion_r1856571212