RFR: 8340731: Cleanup remaining IA64 references in hotspot code [v3]

[Amit Kumar]

On Tue, 26 Nov 2024 07:13:57 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   suggestion from David
>
> src/hotspot/share/runtime/frame.hpp line 167:
> 
>> 165: 
>> 166:   // Every frame needs to return a unique id which distinguishes it from all other frames.
>> 167:   // For sparc and ia32 use sp. ia64 can have memory frames that are empty so multiple frames
> 
> For now the IA32 part should remain.

I have restored IA32 comment in the latest commit.

> src/hotspot/share/runtime/javaCalls.cpp line 121:
> 
>> 119:   // Do this after the transition because this allows us to put an assert
>> 120:   // the Java->vm transition which checks to see that stack is not walkable
>> 121:   // which will catch violations of the resetting of last_Java_frame
> 
> Not clear the comment is still valid given we no longer have sparc or ia64 support.

should I remove this whole comment then ?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22382#discussion_r1857955534
PR Review Comment: https://git.openjdk.org/jdk/pull/22382#discussion_r1857951132