RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations [v5]

Andrew Dinn adinn at openjdk.org
Tue Nov 26 09:48:51 UTC 2024


On Thu, 21 Nov 2024 17:50:57 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Implementation of JDK-8343767
>
> Andrew Dinn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 55 additional commits since the last revision:
> 
>  - Merge branch 'master' into iterate_stubs
>  - fix element sizes in s390 copy routines
>  - fix stub is and align flags for s390
>  - fix comments and remove unused stubid on riscv
>  - locate super lookup stubs in same blob for all arches
>  - do verification under ifdef ASSERT
>  - fix yet more problems with s390 stubs
>  - better error notification
>  - fix more problems with s390 stubs
>  - Verify stubs are generated in correct blob
>  - ... and 45 more: https://git.openjdk.org/jdk/compare/4ea1625c...e21268c4

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 512:

> 510:     break;
> 511:   case jlong_disjoint_arraycopy_id:
> 512:     shift = 0;

Ok, this is one error -- shift should be 3

src/hotspot/cpu/x86/stubGenerator_x86_64_arraycopy.cpp line 850:

> 848:     break;
> 849:   case jlong_arraycopy_id:
> 850:     shift = 0;

and this is another -- again should be 3

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1858150921
PR Review Comment: https://git.openjdk.org/jdk/pull/21957#discussion_r1858151684


More information about the hotspot-dev mailing list