RFR: 8345047: RISC-V: Remove explicit use of AvoidUnalignedAccesses in interpreter

Hamlin Li mli at openjdk.org
Tue Nov 26 11:17:40 UTC 2024


On Tue, 26 Nov 2024 10:19:40 GMT, Fei Yang <fyang at openjdk.org> wrote:

> Hi, please consider this small interpreter cleanup change.
> 
> The use of `AvoidUnalignedAccesses` option for these cases doen't much sense to me.
> MacroAssembler routines like `revb_h_h_u` and `revb_h_h` will emit 5 instructions when Zbb extension is not available. This is more than the case when `AvoidUnalignedAccesses` option is true. After this change, we always emit 4 instructions compared to 3 instructions in the case when we have Zbb extension. But I don't think it will make a difference.
> 
> Testing on linux-riscv64 platform:
> - [x] tier1 (release)

Looks good. Thanks!
Since the changes are in the interpreter, I can accept minor regressions introduced in exchange for code readability.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22387#pullrequestreview-2461157508


More information about the hotspot-dev mailing list