RFR: 8340731: Cleanup remaining IA64 references in hotspot code [v4]

David Holmes dholmes at openjdk.org
Wed Nov 27 06:33:49 UTC 2024


On Wed, 27 Nov 2024 05:04:24 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

>> This PR cleans up `IA64` entries form hotspot codebase. 
>> 
>> As mentioned in the JBS, I left `zero` component as-it-is: 
>> 
>> ./cpu/zero/bytecodeInterpreter_zero.hpp:31:#if defined(PPC) || defined(IA64)
>> ./os_cpu/linux_zero/os_linux_zero.cpp:350:#ifdef IA64
>> ./os_cpu/linux_zero/os_linux_zero.cpp:351:    // IA64 has two stacks sharing the same area of memory, a normal
>> ./os_cpu/linux_zero/os_linux_zero.cpp:360:#endif // IA64
>> 
>> 
>> Fastdebug VM Build on Mac-M1 & Linux/s390x is fine. Tests are in progress.
>
> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
> 
>   removes comment

Changes requested by dholmes (Reviewer).

src/hotspot/share/runtime/javaCalls.cpp line 122:

> 120:   // the Java->vm transition which checks to see that stack is not walkable
> 121:   // on sparc/ia64 which will catch violations of the resetting of last_Java_frame
> 122:   // invariants (i.e. _flags always cleared on return to Java)

Sorry please restore the first line.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22382#pullrequestreview-2464009412
PR Review Comment: https://git.openjdk.org/jdk/pull/22382#discussion_r1860011698


More information about the hotspot-dev mailing list