RFR: 8344306: RISC-V: Add zicond [v2]
Fei Yang
fyang at openjdk.org
Wed Nov 27 08:12:41 UTC 2024
On Wed, 27 Nov 2024 07:49:20 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider.
>>
>> In cpu models we save ~1 cycle per removed branch.
>> This patch removes ~0.1% of branches in generic C2 generated code.
>> We should probably investigate if we can improve/add peephole optimization to remove more branches.
>>
>> As the C1 cmov code is a bit tricky I left that as a followup.
>>
>> I added gtests for the cmovs.
>> (we should add coverage for more of masm in this gtest suit)
>> Pro tip, invoke the gtestLauncher directly (you only need to build exploded):
>> `gtestLauncher -jdk build/linux-riscv64-server-fastdebug/jdk/ --gtest_break_on_failure --gtest_filter="*RiscV*" -XX:+UnlockDiagnosticVMOptions -XX:+UseZicond -XX:ParallelGCThreads=1 -XX:ConcGCThreads=1 -XX:CICompilerCount=2`
>>
>> Tested on Spacemit X60, gtests and tier1.
>>
>> Thanks, Robbin
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comments
Update change looks good. I am OK if we want to leave other optimization opportunities to some follow-up PR. Up to you!
-------------
Marked as reviewed by fyang (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22386#pullrequestreview-2464244983
More information about the hotspot-dev
mailing list